[data.search] Clean up code around ES preference usage #204076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
Feature:Search
lukasolson
added
the
release_note:skip
…ana into search_cleanup_preference
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
markov00
approved these changes
Dec 19, 2024
src/plugins/data/common/search/search_source/fetch/get_search_params.ts
Outdated
Show resolved
Hide resolved
…params.ts Co-authored-by: Marco Vettorello <[email protected]>
davismcphee
approved these changes
Jan 3, 2025
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Page load bundle
History
cc @lukasolson |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 6, 2025
## Summary While refreshing my memory on how we are using the Elasticsearch `preference` parameter, I noticed we had a method `getEsPreference` that was exported but not used. We then had an additional method `getPreference` that was being used to actually set the parameter. I consolidated these into one place and moved the tests so that we can utilize it when ES|QL supports this parameter. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Marco Vettorello <[email protected]> (cherry picked from commit df3665f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 7, 2025
#205661) # Backport This will backport the following commits from `main` to `8.x`: - [[data.search] Clean up code around ES preference usage (#204076)](#204076) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lukas Olson","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-06T22:02:48Z","message":"[data.search] Clean up code around ES preference usage (#204076)\n\n## Summary\r\n\r\nWhile refreshing my memory on how we are using the Elasticsearch\r\n`preference` parameter, I noticed we had a method `getEsPreference` that\r\nwas exported but not used. We then had an additional method\r\n`getPreference` that was being used to actually set the parameter. I\r\nconsolidated these into one place and moved the tests so that we can\r\nutilize it when ES|QL supports this parameter.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Vettorello <[email protected]>","sha":"df3665fbf59295dfbd664dfc280658b5232498d9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Search","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[data.search] Clean up code around ES preference usage","number":204076,"url":"https://github.com/elastic/kibana/pull/204076","mergeCommit":{"message":"[data.search] Clean up code around ES preference usage (#204076)\n\n## Summary\r\n\r\nWhile refreshing my memory on how we are using the Elasticsearch\r\n`preference` parameter, I noticed we had a method `getEsPreference` that\r\nwas exported but not used. We then had an additional method\r\n`getPreference` that was being used to actually set the parameter. I\r\nconsolidated these into one place and moved the tests so that we can\r\nutilize it when ES|QL supports this parameter.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Vettorello <[email protected]>","sha":"df3665fbf59295dfbd664dfc280658b5232498d9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204076","number":204076,"mergeCommit":{"message":"[data.search] Clean up code around ES preference usage (#204076)\n\n## Summary\r\n\r\nWhile refreshing my memory on how we are using the Elasticsearch\r\n`preference` parameter, I noticed we had a method `getEsPreference` that\r\nwas exported but not used. We then had an additional method\r\n`getPreference` that was being used to actually set the parameter. I\r\nconsolidated these into one place and moved the tests so that we can\r\nutilize it when ES|QL supports this parameter.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Vettorello <[email protected]>","sha":"df3665fbf59295dfbd664dfc280658b5232498d9"}}]}] BACKPORT--> Co-authored-by: Lukas Olson <[email protected]>
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
## Summary While refreshing my memory on how we are using the Elasticsearch `preference` parameter, I noticed we had a method `getEsPreference` that was exported but not used. We then had an additional method `getPreference` that was being used to actually set the parameter. I consolidated these into one place and moved the tests so that we can utilize it when ES|QL supports this parameter. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Marco Vettorello <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary While refreshing my memory on how we are using the Elasticsearch `preference` parameter, I noticed we had a method `getEsPreference` that was exported but not used. We then had an additional method `getPreference` that was being used to actually set the parameter. I consolidated these into one place and moved the tests so that we can utilize it when ES|QL supports this parameter. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Marco Vettorello <[email protected]>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
## Summary While refreshing my memory on how we are using the Elasticsearch `preference` parameter, I noticed we had a method `getEsPreference` that was exported but not used. We then had an additional method `getPreference` that was being used to actually set the parameter. I consolidated these into one place and moved the tests so that we can utilize it when ES|QL supports this parameter. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Marco Vettorello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While refreshing my memory on how we are using the Elasticsearch
preferenceparameter, I noticed we had a methodgetEsPreferencethat was exported but not used. We then had an additional methodgetPreferencethat was being used to actually set the parameter. I consolidated these into one place and moved the tests so that we can utilize it when ES|QL supports this parameter.Checklist